Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernise setup scripts #484

Merged
merged 18 commits into from
Sep 26, 2024
Merged

Modernise setup scripts #484

merged 18 commits into from
Sep 26, 2024

Conversation

trexfeathers
Copy link
Collaborator

🚀 Pull Request

Description

Closes #454

@trexfeathers
Copy link
Collaborator Author

Proof that the project metadata's new location still delivers something meaningful:

https://test.pypi.org/project/cf-units/3.2.1.dev83

pelson
pelson reviewed Sep 26, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
pelson
pelson reviewed Sep 26, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
pelson
pelson reviewed Sep 26, 2024
View reviewed changes
setup.py Show resolved Hide resolved
pelson
pelson previously approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@pelson pelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few small suggestions, but they are non-essential (and could e followed up separately).

@trexfeathers trexfeathers marked this pull request as ready for review September 26, 2024 13:39
@trexfeathers trexfeathers mentioned this pull request Sep 26, 2024
Merged
pp-mo
pp-mo approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 tiny quibble
rest OK afaict, but still worryingly intricate + complex (if less obsolete).
Not your fault, I guess we just need it, for now.

pyproject.toml Show resolved Hide resolved
setup.py Show resolved Hide resolved
pp-mo
pp-mo requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops approved by mistake

pyproject.toml Outdated Show resolved Hide resolved
pp-mo
pp-mo approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pp-mo pp-mo merged commit 4d441ba into SciTools:main Sep 26, 2024
14 checks passed
@pp-mo
Copy link
Member

pp-mo commented Sep 26, 2024

Hope I'm not premature here.
We had an oustanding suggestion from @pelson on the optional deps section in pyproject.toml
But I think that was done OK now.

@trexfeathers
Copy link
Collaborator Author

Thanks @pp-mo!

And yes 9cf0ace took care of the optional deps

stephenworsley added a commit to stephenworsley/cf-units that referenced this pull request Sep 27, 2024
@stephenworsley
Merge branch 'main' into numpy-2
6b433ab 
* main:
  [DOCS] Update docstring for date2num (module function) (SciTools#483)
  Modernise setup scripts (SciTools#484)
  Make antlr optional (SciTools#423)
  Ruff: smaller steps (SciTools#364)
  Updated docstring for num2date. (SciTools#467)
  updated conda lock files (SciTools#479)
  Revert to 00:03 Mondays for lockfile updates. (SciTools#480)
  New trigger time for GMT. (SciTools#478)
  Check lockfile updates @ 3pm daily (temporary for testing). (SciTools#477)
  Fixlocks (SciTools#470)

# Conflicts:
#	pyproject.toml
#	requirements/cf-units.yml
#	requirements/locks/py310-lock-linux-64.txt
#	requirements/locks/py310-lock-osx-64.txt
#	requirements/locks/py310-lock-win-64.txt
#	requirements/locks/py311-lock-linux-64.txt
#	requirements/locks/py311-lock-osx-64.txt
#	requirements/locks/py311-lock-win-64.txt
#	requirements/locks/py312-lock-linux-64.txt
#	requirements/locks/py312-lock-osx-64.txt
#	requirements/locks/py312-lock-win-64.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pp-mo pp-mo pp-mo approved these changes

@pelson pelson pelson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update build system : adopt PEP517/8
3 participants
@trexfeathers @pp-mo @pelson