Add nearest neighbour regridding #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #266 +/- ##
==========================================
+ Coverage 98.73% 98.79% +0.05%
==========================================
Files 30 33 +3
Lines 3323 3563 +240
==========================================
+ Hits 3281 3520 +239
- Misses 42 43 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
for more information, see https://pre-commit.ci
trexfeathers
requested changes
May 15, 2023
There was a problem hiding this comment.
Nice work @stephenworsley. My comments are below 🙂
Is nearest neighbour deliberately not an option in unstructured_scheme? E.g.:
for more information, see https://pre-commit.ci
* origin/nearest: [pre-commit.ci] auto fixes from pre-commit.com hooks
trexfeathers
requested changes
May 16, 2023
There was a problem hiding this comment.
Last couple of changes:
✔ Places that still don't list "nearest"
"nearest"- https://github.com/SciTools-incubator/iris-esmf-regrid/blob/ae31e051c446aa12e60eda68a8aac6d278671058/esmf_regrid/experimental/unstructured_scheme.py#L131
- https://github.com/SciTools-incubator/iris-esmf-regrid/blob/ae31e051c446aa12e60eda68a8aac6d278671058/esmf_regrid/experimental/unstructured_scheme.py#L301
#263 will help avoid things like this in future I hope 🤞
✔ Missed comment: #266 (comment)
trexfeathers
approved these changes
May 16, 2023
HGWright
pushed a commit
to HGWright/iris-esmf-regrid
that referenced
this pull request
May 19, 2023
* add nearest neighbour regridding * fix tests * further improvements, reintroduce mask keywords * fix tests * change test name * add tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * flake fix * update changelog * address review comments * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * flake fix * address review comments * parameterise test * add Raises section to docstrings * fix docstrings * fill out __all__ * address review comments * further test parameterisation. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
trexfeathers
added a commit
that referenced
this pull request
May 23, 2023
* adding gha for tests and wheels * get wheels to run * 1st wheels fix * 2nd fix * 3rd fix * 4th fix * 5th fix * 6th fix * 7th fix * 8th fix * 9th fix * 10th fix * 11th fix * 12th fix * 13th fix * 14th fix * 15th fix * 15th fix * 16th fix * 18th fix * 19th fix * 20th fix * 21st fix * 22nd fix * 23rd fix * 24th fix * 25th fix * 26th fix * 27th fix * 28th fix * 29th fix * 29th fix * 30th fix * 31st fix * 32nd fix * 33rd fix * 34th fix * 35th fix * 36th fix * 37th fix * 38th fix * 39th fix * 40th fix * 41ST fix * 42nd fix * 43rd fix * 44th fix * 45th fix * 45th fix * 46th fix * 47th fix * 48th fix * 49th fix * 50th fix * 51st fix * 52nd fix * 53rd fix * 54th fix * 55th fix * 56th fix * 57th fix * 58th fix * 59th fix * Adding GHA to replace cirrus.yml * Adding comments for IRIS_SOURCE * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixing the name of the benchmark check * Fixing the name of the benchmark check again * Add nearest neighbour regridding (#266) * add nearest neighbour regridding * fix tests * further improvements, reintroduce mask keywords * fix tests * change test name * add tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * flake fix * update changelog * address review comments * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * flake fix * address review comments * parameterise test * add Raises section to docstrings * fix docstrings * fill out __all__ * address review comments * further test parameterisation. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Fixing the name of the benchmark check * Making requested changes * Update .github/workflows/benchmark.yml Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> * add comment to benchmark.yml * Update .github/workflows/benchmark.yml Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: stephenworsley <49274989+stephenworsley@users.noreply.github.com> Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates the minimal version of nearest neighbour regridding described in #213.
This also incidentally fixes a slight error in the refactoring where ESMFBilinear didn't have a
use_src_maskanduse_tgt_maskkeyword.