Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix start index bug #301

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Fix start index bug #301

merged 2 commits into from
Aug 30, 2023

Conversation

stephenworsley
Copy link
Contributor

Addresses #300.

@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

Merging #301 (92c8722) into main (6658920) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #301   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files          33       33           
  Lines        3642     3646    +4     
=======================================
+ Hits         3596     3600    +4     
  Misses         46       46
Files Changed Coverage Δ
esmf_regrid/experimental/unstructured_regrid.py 97.50% <100.00%> (+0.13%) ⬆️
...nstructured_scheme/test_GridToMeshESMFRegridder.py 100.00% <100.00%> (ø)
...nstructured_scheme/test_MeshToGridESMFRegridder.py 97.12% <100.00%> (+0.01%) ⬆️
...egrid/tests/unit/schemes/test__mesh_to_MeshInfo.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pp-mo
pp-mo approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.
The use of test parameters is neat !

@pp-mo pp-mo merged commit 70f3c25 into SciTools:main Aug 30, 2023
12 checks passed
@stephenworsley stephenworsley mentioned this pull request Aug 30, 2023
Closed
stephenworsley added a commit to stephenworsley/iris-esmf-regrid that referenced this pull request Aug 31, 2023
@stephenworsley
Merge branch 'main' into pre-commit-ci-update-config_fix
95b70a7 
* main:
  Bump scitools/workflows from 2023.05.0 to 2023.06.0 (SciTools#282)
  Updated environment lockfiles (SciTools#296)
  Fix start index bug (SciTools#301)
  extending stale GHA time (SciTools#302)
  ASV v0.6 - no longer use strict parameter. (SciTools#297)
  update to v0.9.dev0 (SciTools#299)
  update to v0.8.0 (SciTools#298)
  Add option to initialise from mesh (SciTools#289)
  Updated environment lockfiles (SciTools#295)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pp-mo pp-mo pp-mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenworsley @pp-mo