Python 3 builtins via six #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| This is a really, really, really, really long long_name that must be clipped... x |
|
If tests pass 👍. Please keep 3c9fc9f as a base commit, putting subsequent work on top of that. |
Closed
|
OK, tests pass, but there might be one |
QuLogic
force-pushed
the
py3k-six-builtins
branch
from
3c9fc9f to
41deaa9
Compare
|
Ah, I just missed the |
|
Seems problematic... |
In some cases, switch to np.arange where it's clearer.
In most cases, no other changes were necessary since the result was used in a for loop.
Again, mostly unchanged except for the import.
Modernize seems to want to turn most filter calls into list comprehensions.
QuLogic
force-pushed
the
py3k-six-builtins
branch
from
41deaa9 to
77335a5
Compare
|
Oops, I shouldn't do this so late at night... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the builtins that are different on Python 3 using
six. This only includes changes in files where these functions are used. I'll open a second PR adding these new builtins to the remaining files later.