Remove some @tests.skip_biggus that are now unnecessary
#2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbdreyer
force-pushed
the
skip_biggus_tests_0
branch
from
0ac0500
to
e298701
Compare
|
@lbdreyer Awesome, thanks 👍 |
Is |
|
@dkillick Yeah, the We could also then look into sorting the xml elements into an order that we prefer |
See #2448 so we do intend to remove core-dtype at some point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some of the skippers that were put in place for the Iris-dask integration since they are no longer needed.
The cml has change for some due to core-dtype, dtype and fill value becoming cube attributes
Relevant Issue: #2398
There are still some outstanding tests that have skippers in them but they are a bit more complicated so I will deal with them in later PRs