Remove skip_biggus from unit/fileformats/test_rules.py #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbdreyer
changed the title
lbdreyer
changed the title
lbdreyer
force-pushed
the
skip_biggus_tests_0
branch
from
254172b
to
81305de
Compare
lbdreyer
force-pushed
the
skip_biggus_tests_0
branch
from
81305de
to
9d14ce7
Compare
lbdreyer
changed the title
DPeterK
reviewed
May 15, 2017
| field = mock.Mock() | ||
| field.core_data = mock.Mock() | ||
| # Add a compute attribute so that the data will be treated as lazy. | ||
| field.core_data.compute = None |
There was a problem hiding this comment.
OK, I don't understand why the mock object needs to pretend to be lazy (the test runs just fine without this line). I also don't see this line as a deal-breaker, though...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated this PR so it only deals with the removal of the biggus skipper from:
unit/fileformats/test_rules.py