Fix for numpy 1v16. #3257
Merged
Fix for numpy 1v16. #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp-mo
commented
Feb 1, 2019
| # Ensure we have a writeable data buffer. | ||
| # NOTE: "data.setflags(write=True)" is not valid for numpy >= 1.16.0. | ||
| if not data.flags['WRITEABLE']: | ||
| data = data.copy() |
There was a problem hiding this comment.
Note: 'data' is generated within this routine, not passed in.
So I think this is a safe change.
Merged
|
Ping @pp-mo 👍 |
bjlittle
pushed a commit
that referenced
this pull request
Feb 1, 2019
znicholls
pushed a commit
to znicholls/iris
that referenced
this pull request
Jun 15, 2019
* BLD: Pinning cftime to 1.0.1 (SciTools#3247) * Fix for numpy 1v16. (SciTools#3257)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem triggered by numpy >= 1.16.
Can no longer simply "make" an array writeable by writing the flag.
There's actually only one place we do that. It was probably a bit cheeky anyway ...