Update CI environment lockfiles + Cartopy 0.19 changes #4125
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Something very weird is going on with that gallery example. The idiff looks like this:
So the map is getting cropped somehow. I tried plotting just the first time from the original cube qplt.contourf(cube[0])
plt.gca().coastlines()
plt.show()which gave the full, uncropped map. I also tried plotting directly with cartopy: plt.subplot(111, projection=ccrs.PlateCarree())
plt.contourf(warm_periods.coord('longitude').points,
warm_periods.coord('latitude').points,
warm_periods.data, transform=ccrs.PlateCarree(),
cmap="RdYlBu_r")
plt.gca().coastlines()
plt.show()and that also gave the full uncropped map. |
|
These two also have some cropping. The other four failure diffs just looked like very minor shifts in position to me. |
|
Back to the gallery example: I just tried it again with |
|
Interesting. There is something strange with that antialias code that came up in a surgery that I never got to the bottom of - #4086. Related? |
|
That antialias code is seriously old and appears to be a workaround for a problem that was noted at the time. I'm wondering: has anyone checked recently whether the problem still exists and the workaround is still required? |
|
@jamesp what happens now? Presumably it's OK to merge one of these PR's once the tests pass? |
|
Nice! All passing :) well done @rcomer, that was a bit of a mission. @trexfeathers yes it should be fine to merge this now. Next Saturday a new PR will be created if there are any version increases on conda-forge since the last check. if not, nothing will happen. You may want to rename this PR to something more cartopy 0.19 related! |
|
@rcomer you deserve the merge 🙂 |
rcomer
changed the title
rcomer
changed the title
|
Whooooooop |
* master: (49 commits) Update CI environment lockfiles + Cartopy 0.19 changes (SciTools#4125) separate arg types from descriptions (SciTools#4100) Use assertArrayAllClose for sqrt test (SciTools#4118) Removed branch suffix (SciTools#4117) Corrected plot_anomaly_log_colouring for new Matplotlib linscale rules. (SciTools#4115) replace most recent hashes (SciTools#4112) Linkcheck update (SciTools#4104) CI lockfiles (SciTools#4108) Fix bug in gallery_tests runner (SciTools#4111) add logo to conda and pypi badges (SciTools#4088) pre-commit-ci update (SciTools#4092) Fix cirrus ci and mpl (SciTools#4087) Update readme docs stable (SciTools#4089) linux kernel version fix for conda 4.10+ (SciTools#4084) update docs pypi instructions (SciTools#4077) update flake8 pre-commit (SciTools#4067) Add GitHub discussions badge (SciTools#4070) conda requirements add pip (SciTools#4062) add pre-commit.ci badge and doc support (SciTools#4061) cirrus-ci credits for non-master (SciTools#4060) ...
* master: (87 commits) Contourf Antialias Fix (SciTools#4150) minor tidy of cirrus and nox (SciTools#4152) update bug and feature templates (SciTools#4147) Update CI environment lockfiles + Cartopy 0.19 changes (SciTools#4125) separate arg types from descriptions (SciTools#4100) Use assertArrayAllClose for sqrt test (SciTools#4118) Removed branch suffix (SciTools#4117) Corrected plot_anomaly_log_colouring for new Matplotlib linscale rules. (SciTools#4115) replace most recent hashes (SciTools#4112) Linkcheck update (SciTools#4104) CI lockfiles (SciTools#4108) Fix bug in gallery_tests runner (SciTools#4111) add logo to conda and pypi badges (SciTools#4088) pre-commit-ci update (SciTools#4092) Fix cirrus ci and mpl (SciTools#4087) Update readme docs stable (SciTools#4089) linux kernel version fix for conda 4.10+ (SciTools#4084) update docs pypi instructions (SciTools#4077) update flake8 pre-commit (SciTools#4067) Add GitHub discussions badge (SciTools#4070) ...
Lockfiles updated to the latest resolvable environment.