Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mergeback after v3.7.0 release #5454

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Mergeback after v3.7.0 release #5454

merged 3 commits into from
Dec 7, 2023

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Aug 31, 2023

Proposed v3.7.0 mergeback

NOTES:


Consult Iris pull request check list

* Whats new updates for v3.7.0 .

* Improve whatsnew and standardise its formatting.
@pp-mo pp-mo marked this pull request as draft August 31, 2023 16:42
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db43fde) 89.68% compared to head (b7c3f68) 89.37%.

❗ Current head b7c3f68 differs from pull request most recent head 875e890. Consider uploading reports for the commit 875e890 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5454      +/-   ##
==========================================
- Coverage   89.68%   89.37%   -0.32%     
==========================================
  Files          90       89       -1     
  Lines       22818    22443     -375     
  Branches     5446     5381      -65     
==========================================
- Hits        20465    20058     -407     
- Misses       1619     1639      +20     
- Partials      734      746      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pp-mo pp-mo changed the title Whats new updates for v3.7.0 . (#5451) Mergeback after v3.7.0 release Aug 31, 2023
@lbdreyer
Copy link
Member

if we change the citation text, see #5453 , then that should also be included here (before merging)

Personally I'd rather this not be delayed by that, especially if it is going to be much longer. Currently the latest Iris docs looks like:

image

Which is out of date and may be confusing to a user. At least I was temporarily confused by it!

@lbdreyer
Copy link
Member

lbdreyer commented Nov 2, 2023

Bump for this to happen!

#5526 removed the release candidate ref but added the wrong release date.

This at least needs to go in before the Iris 3.8 release. But really should have gone in as part of the 3.7 work

@trexfeathers
Copy link
Contributor

Bump for this to happen!

#5526 removed the release candidate ref but added the wrong release date.

This at least needs to go in before the Iris 3.8 release. But really should have gone in as part of the 3.7 work

Hahah that was also a jinx moment! @pp-mo @HGWright how come this is still here? Do you need help from any of us?

pp-mo and others added 2 commits December 7, 2023 15:56
* Possible citation updates -- not clear whether appropriate.

* Update docs/src/userguide/citation.rst

revert conversion to url -- it should be a bare DOI
@trexfeathers trexfeathers marked this pull request as ready for review December 7, 2023 16:14
@trexfeathers trexfeathers merged commit d510bb8 into main Dec 7, 2023
30 checks passed
@trexfeathers trexfeathers deleted the v3.7.x branch December 7, 2023 16:14
@pp-mo
Copy link
Member Author

pp-mo commented Dec 8, 2023

Thanks for chasing this down @trexfeathers -- I had forgotten it altogether !

@trexfeathers trexfeathers restored the v3.7.x branch February 29, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants