Add an auto-labeller to always benchmark lock file changes #5763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trexfeathers
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5763 +/- ##
=======================================
Coverage 89.74% 89.74%
=======================================
Files 92 92
Lines 22940 22940
Branches 5462 5462
=======================================
Hits 20588 20588
Misses 1620 1620
Partials 732 732 ☔ View full report in Codecov by Sentry. |
HGWright
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Looks good @trexfeathers , hopefully this will make us more aware of performance regressions going forward!
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Feb 23, 2024
…umpydoc-pre-commit * 'numpydoc-pre-commit' of github.com:tkknight/iris: Update documentation for the new v5 CLA. (SciTools#5664) Add an auto-labeller to always benchmark lock file changes (SciTools#5763)
trexfeathers
added a commit
to trexfeathers/iris
that referenced
this pull request
Feb 23, 2024
…ciTools#5763)" This reverts commit 9397c1d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Dependency changes are the most common cause of performance regressions, but we often forget to benchmark these changes so things get missed.
Note that the labeler will not run in this pull request - the one that introduces it.
To do
Consult Iris pull request check list