Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy median aggregator #6167

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Lazy median aggregator #6167

wants to merge 4 commits into from

Conversation

fnattino
Copy link
Contributor

@fnattino fnattino commented Oct 8, 2024

🚀 Pull Request

Description

Adding the lazy implementation of the median aggregator, following the implementation discussed in #4039 .

It is true that the issue above suggests that there was not much interest for a lazy median, but it looked like it would need only little effort. And we thought it could still be useful to some ESMValTool users who might not be aware of the workaround of using the 50th percentile.

CC: @bouweandela

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.81%. Comparing base (cc60a60) to head (4ea685e).

Files with missing lines Patch % Lines
lib/iris/analysis/__init__.py 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6167      +/-   ##
==========================================
- Coverage   89.81%   89.81%   -0.01%     
==========================================
  Files          88       88              
  Lines       23174    23182       +8     
  Branches     5045     5046       +1     
==========================================
+ Hits        20814    20821       +7     
  Misses       1623     1623              
- Partials      737      738       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant