Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate travis-ci to cirrus-ci #66

Merged
merged 4 commits into from
Jun 10, 2021
Merged

migrate travis-ci to cirrus-ci #66

merged 4 commits into from
Jun 10, 2021

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented Jun 9, 2021 •
edited
Loading

🚀 Pull Request

Description

This PR shows some much need ❤️ to nc-time-axis.

For fuller details see the associated Issue #63.

Note that, in order to reboot the CI, I've folding in the following awesome contributions:

This PR will also close:

Closes #63

@bjlittle bjlittle added this to the v1.3.0 milestone Jun 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@0ec3b51). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #66   +/-   ##
=========================================
  Coverage          ?   89.14%           
=========================================
  Files             ?        1           
  Lines             ?      175           
  Branches          ?       42           
=========================================
  Hits              ?      156           
  Misses            ?       13           
  Partials          ?        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ec3b51...08caec3. Read the comment docs.

@bjlittle bjlittle force-pushed the migrate-travis-ci-to-cirrus-ci branch from defc2fc to 78b7e6e Compare June 9, 2021 10:33
@bjlittle bjlittle mentioned this pull request Jun 9, 2021
Merged
lbdreyer
lbdreyer reviewed Jun 9, 2021
View reviewed changes
Copy link
Member

@lbdreyer lbdreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far! A really great improvement!

I have a few minor things to look through (I'll do these tomorrow) but I thought I'd submit the few minor comments I had so far

.flake8 Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
nc_time_axis/tests/integration/test_plot.py Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
trexfeathers
trexfeathers reviewed Jun 10, 2021
View reviewed changes
.cirrus.yml Outdated Show resolved Hide resolved
lbdreyer
lbdreyer reviewed Jun 10, 2021
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
lbdreyer
lbdreyer reviewed Jun 10, 2021
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@bjlittle bjlittle mentioned this pull request Jun 10, 2021
Closed
@lbdreyer
Copy link
Member

Looks like this is good to go!

Thanks for working on this @bjlittle !

@lbdreyer lbdreyer merged commit 865dc22 into SciTools:master Jun 10, 2021
@bjlittle
Copy link
Member Author

@lbdreyer Awesome! 🥳 🍻

This was referenced Jun 10, 2021
Closed
Closed
Closed
Closed
This was referenced Jun 10, 2021
Closed
Closed
Closed
ocefpaf
ocefpaf reviewed Jun 10, 2021
View reviewed changes
requirements/py39.yml
- conda-forge

dependencies:
- python 3.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need an env file for each Python version? That will be an extra burden to maintain :-/

@bjlittle bjlittle deleted the migrate-travis-ci-to-cirrus-ci branch June 10, 2021 20:37
@trexfeathers trexfeathers mentioned this pull request Jun 11, 2021
Closed
trexfeathers
trexfeathers reviewed Jun 14, 2021
View reviewed changes
nc_time_axis/__init__.py
1,
1,
calendar=self.calendar,
**has_year_zero(year),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry not to have caught this before merge. has_year_zero was only introduced as a kwarg in Unidata/cftime#234, which means the cftime requirement should be pinned: cftime>=1.5.

(I think this ought to fix the nc-time-axis failures on SciTools/iris#4194, although it's hard to tell if it's the root cause).

@trexfeathers trexfeathers mentioned this pull request Jun 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocefpaf ocefpaf ocefpaf left review comments

@lbdreyer lbdreyer lbdreyer left review comments

@mathause mathause mathause left review comments

@rcomer rcomer rcomer left review comments

@trexfeathers trexfeathers trexfeathers left review comments

@spencerkclark spencerkclark Awaiting requested review from spencerkclark

@aulemahal aulemahal Awaiting requested review from aulemahal

Assignees
No one assigned
Labels
New: Pull Request Highlight a new community raised pull-request Type: Enhancement Type: Infrastructure Type: Testing
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Reboot nc-time-axis
7 participants
@bjlittle @codecov-commenter @lbdreyer @ocefpaf @mathause @rcomer @trexfeathers