-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added bulk reassignment of workspaces roles #5958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I validate the file misc/generate_pyqt.py
2c0f13b
to
2c74874
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some suggestions regarding the docs, otherwise LGTM 👍
Also, can you regenerate the images to replace the "Toto" user and its mail? It may seem like a detail, but it makes the docs look unprofessional
c82f04c
to
b5a0294
Compare
b5a0294
to
f746298
Compare
f746298
to
9fe0d7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more suggestions regarding the docs and screenshots.
Otherwise LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The context menu item that opens this dialog is named "Assign workspace roles to another user".
However, once opened, it is not immediately clear what the dialog is about.
Even if that is explained in the following step, I think we can improve it a little bit:
- Title:
Assign Bob workspace roles to:
(with the username emphasized? 🤔) - Description:
Select a user to see the roles that will be assigned.
docs/userguide/share_data.rst
Outdated
Bulk assign workspace roles to users | ||
------------------------------------ | ||
|
||
Assigning the same roles to multiple users on multiple workspaces can be a bit annoying. Parsec provides a way to bulk assign the roles of one user to another. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use "tedious" instead of "annoying":
Assigning the same roles to multiple users on multiple workspaces can be a bit annoying. Parsec provides a way to bulk assign the roles of one user to another. | |
Manually assigning the same workspace roles to multiple users can be a bit tedious and error prone. Parsec provides a way to bulk assign the roles from one user to another. |
In French:
L'assignation manuelle des mêmes rôles d'espace de travail à plusieurs utilisateurs peut s'avérer fastidieuse et source d'erreurs. Parsec propose un moyen d'attribuer en bloc les rôles d'un utilisateur à un autre.
docs/userguide/share_data.rst
Outdated
:align: center | ||
:alt: Select the user to assign roles to | ||
|
||
3. You're shown a summary of what roles are going to be assigned on each workspace. Click on `Assign roles` to complete the operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3. You're shown a summary of what roles are going to be assigned on each workspace. Click on `Assign roles` to complete the operation. | |
3. You're shown a summary of which roles are going to be assigned on each workspace. Click on `Assign roles` to complete the operation. |
docs/userguide/share_data.rst
Outdated
1. You can only assign roles on workspaces where you are an Owner or Manager | ||
2. Outsider cannot have a role higher than Contributor | ||
3. You cannot assign roles higher than your own. If you have the Manager role in a workspace and you're trying to assign the Owner role, it will be downgraded to Contributor). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. You can only assign roles on workspaces where you are an Owner or Manager | |
2. Outsider cannot have a role higher than Contributor | |
3. You cannot assign roles higher than your own. If you have the Manager role in a workspace and you're trying to assign the Owner role, it will be downgraded to Contributor). | |
1. You can only assign roles on a workspace where you have an Owner or Manager role | |
2. An Outsider user cannot have a role higher than Contributor | |
3. You cannot assign roles higher than your own. If you have the Manager role in a workspace and you're trying to assign the Owner role, it will be downgraded to Contributor. |
Closes #5938