Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bulk reassignment of workspaces roles #5958

Merged
merged 6 commits into from
Dec 18, 2023
Merged

Conversation

Max-7
Copy link
Contributor

@Max-7 Max-7 commented Dec 7, 2023

Closes #5938

  1. Can only assign roles on workspaces where the client is Manager or Owner
  2. When assigning to an Outsider, Manager and Owner roles are converted to Contributor
  3. If the client is a Manager, and the role to assign is Manager or Owner, the role assigned becomes Contributor (a Manager cannot set roles higher than Contributor)
  4. If the user has a higher role on the workspace than the one we want to assign, do nothing
  • Keep changes in the pull request as small as possible
  • Ensure the commit history is sanitized
  • Give a meaningful title to your PR
  • Describe your changes
  • Link any related issue in the description

@Max-7 Max-7 requested review from a team as code owners December 7, 2023 13:59
Copy link
Contributor

@FirelightFlagboy FirelightFlagboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I validate the file misc/generate_pyqt.py

@Max-7 Max-7 force-pushed the reassign-workspace-roles branch 2 times, most recently from 2c0f13b to 2c74874 Compare December 8, 2023 13:37
Copy link
Contributor

@mmmarcos mmmarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some suggestions regarding the docs, otherwise LGTM 👍

Also, can you regenerate the images to replace the "Toto" user and its mail? It may seem like a detail, but it makes the docs look unprofessional

parsec/core/gui/tr/parsec_en.po Outdated Show resolved Hide resolved
parsec/core/gui/tr/parsec_fr.po Outdated Show resolved Hide resolved
parsec/core/gui/tr/parsec_fr.po Outdated Show resolved Hide resolved
docs/userguide/share_data.rst Outdated Show resolved Hide resolved
docs/userguide/share_data.rst Outdated Show resolved Hide resolved
docs/userguide/share_data.rst Outdated Show resolved Hide resolved
docs/userguide/share_data.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@mmmarcos mmmarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more suggestions regarding the docs and screenshots.

Otherwise LGTM 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text was changed:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The context menu item that opens this dialog is named "Assign workspace roles to another user".
However, once opened, it is not immediately clear what the dialog is about.

Even if that is explained in the following step, I think we can improve it a little bit:

  • Title: Assign Bob workspace roles to: (with the username emphasized? 🤔)
  • Description: Select a user to see the roles that will be assigned.

Bulk assign workspace roles to users
------------------------------------

Assigning the same roles to multiple users on multiple workspaces can be a bit annoying. Parsec provides a way to bulk assign the roles of one user to another.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use "tedious" instead of "annoying":

Suggested change
Assigning the same roles to multiple users on multiple workspaces can be a bit annoying. Parsec provides a way to bulk assign the roles of one user to another.
Manually assigning the same workspace roles to multiple users can be a bit tedious and error prone. Parsec provides a way to bulk assign the roles from one user to another.

In French:

L'assignation manuelle des mêmes rôles d'espace de travail à plusieurs utilisateurs peut s'avérer fastidieuse et source d'erreurs. Parsec propose un moyen d'attribuer en bloc les rôles d'un utilisateur à un autre.

:align: center
:alt: Select the user to assign roles to

3. You're shown a summary of what roles are going to be assigned on each workspace. Click on `Assign roles` to complete the operation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. You're shown a summary of what roles are going to be assigned on each workspace. Click on `Assign roles` to complete the operation.
3. You're shown a summary of which roles are going to be assigned on each workspace. Click on `Assign roles` to complete the operation.

Comment on lines 94 to 96
1. You can only assign roles on workspaces where you are an Owner or Manager
2. Outsider cannot have a role higher than Contributor
3. You cannot assign roles higher than your own. If you have the Manager role in a workspace and you're trying to assign the Owner role, it will be downgraded to Contributor).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. You can only assign roles on workspaces where you are an Owner or Manager
2. Outsider cannot have a role higher than Contributor
3. You cannot assign roles higher than your own. If you have the Manager role in a workspace and you're trying to assign the Owner role, it will be downgraded to Contributor).
1. You can only assign roles on a workspace where you have an Owner or Manager role
2. An Outsider user cannot have a role higher than Contributor
3. You cannot assign roles higher than your own. If you have the Manager role in a workspace and you're trying to assign the Owner role, it will be downgraded to Contributor.

@Max-7 Max-7 added this pull request to the merge queue Dec 18, 2023
Merged via the queue into dev/v2 with commit 4ad5c5d Dec 18, 2023
12 checks passed
@Max-7 Max-7 deleted the reassign-workspace-roles branch December 18, 2023 15:05
@mmmarcos mmmarcos linked an issue Jan 10, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🚀 | Feature request]: Bulk re-assignment of workspace rights
4 participants