-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MS] User details modal #6000
[MS] User details modal #6000
Conversation
8ebd833
to
ae14741
Compare
dfdd86a
to
733bd52
Compare
.user-details-modal { | ||
--width: 642px; | ||
--height: 468px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is it coming from? copy/paste? is there a specific reflexion behind these values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These values are taken from the mockups, I was unsure if setting them explicitly was necessary or not (and now that you mention it, the height
value is different in the revoked
mockup so I'm guessing it's not)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes in lots of cases the modal will fits its content and it will be good enough.
@fabienSvtr a thought on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
395be0b
to
81af662
Compare
<div> | ||
<ion-text class="text1"> | ||
{{ $t('UsersPage.UserDetailsModal.subtitles.name') }} | ||
</ion-text> | ||
<ion-text class="text1-right"> | ||
{{ $t('UsersPage.UserDetailsModal.subtitles.joined') }} | ||
</ion-text> | ||
</div> | ||
<div> | ||
<ion-text class="text2"> | ||
{{ user.humanHandle.label }} | ||
</ion-text> | ||
<ion-text class="text2-right"> | ||
{{ timeSince(user.createdOn, '--', 'short') }} | ||
</ion-text> | ||
</div> | ||
<div> | ||
<ion-text class="text4"> | ||
{{ $t('UsersPage.UserDetailsModal.subtitles.commonWorkspaces') }} | ||
</ion-text> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the BEM suggestion.
In addition, it is preferable to group the code according to context so that each group/block can be managed (such as the user's name and title).
<div> | |
<ion-text class="text1"> | |
{{ $t('UsersPage.UserDetailsModal.subtitles.name') }} | |
</ion-text> | |
<ion-text class="text1-right"> | |
{{ $t('UsersPage.UserDetailsModal.subtitles.joined') }} | |
</ion-text> | |
</div> | |
<div> | |
<ion-text class="text2"> | |
{{ user.humanHandle.label }} | |
</ion-text> | |
<ion-text class="text2-right"> | |
{{ timeSince(user.createdOn, '--', 'short') }} | |
</ion-text> | |
</div> | |
<div> | |
<ion-text class="text4"> | |
{{ $t('UsersPage.UserDetailsModal.subtitles.commonWorkspaces') }} | |
</ion-text> | |
</div> | |
<div class="detail-name"> | |
<ion-text class="details-name__title"> | |
{{ $t('UsersPage.UserDetailsModal.subtitles.name') }} | |
</ion-text> | |
<ion-text class="detail-name__fullname"> | |
{{ user.humanHandle.label }} | |
</ion-text> | |
</div> | |
<div class="detail-joined"> | |
<ion-text class="detail-joined__title"> | |
{{ $t('UsersPage.UserDetailsModal.subtitles.joined') }} | |
{{ user.humanHandle.label }} | |
</ion-text> | |
<ion-text class=class="detail-joined__date"> | |
{{ timeSince(user.createdOn, '--', 'short') }} | |
</ion-text> | |
</div> | |
<div> | |
<ion-text class="text4"> | |
{{ $t('UsersPage.UserDetailsModal.subtitles.commonWorkspaces') }} | |
</ion-text> | |
</div> |
5fd1a1d
to
ca5e388
Compare
ca5e388
to
449a3f8
Compare
449a3f8
to
c31dcbc
Compare
Describe your changes
Closes #5974
Checklist
Before you submit this pull request, please make sure to:
If this PR adds a new feature or fixes a bug:
If this PR is related to GUI: