Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use asyncpg pool for the notification connection #8435

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

vxgmichel
Copy link
Contributor

This way, the PARSEC_DB_MIN_CONNECTIONS/PARSEC_DB_MAX_CONNECTIONS configuration will correctly reflect the number of connections made to the database.

@vxgmichel vxgmichel requested a review from a team as a code owner September 18, 2024 11:59
Copy link
Member

@touilleMan touilleMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some validation in the CLI to ensure min/max connections are valid

@FirelightFlagboy FirelightFlagboy added this pull request to the merge queue Sep 20, 2024
@touilleMan touilleMan removed this pull request from the merge queue due to a manual request Sep 20, 2024
@touilleMan touilleMan force-pushed the use-pool-for-notification-connection branch from 2dabc32 to c3f3536 Compare September 20, 2024 14:06
@touilleMan touilleMan added this pull request to the merge queue Sep 20, 2024
Merged via the queue into master with commit 9e7aa1f Sep 20, 2024
11 of 12 checks passed
@touilleMan touilleMan deleted the use-pool-for-notification-connection branch September 20, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants