Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rust toolchain #8452

Merged
merged 10 commits into from
Sep 19, 2024
Merged

Bump Rust toolchain #8452

merged 10 commits into from
Sep 19, 2024

Conversation

FirelightFlagboy
Copy link
Contributor

No description provided.

Copy link
Contributor

@AureliaDolo AureliaDolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know about inspect it's nice ✨

Comment on lines +67 to +70
unexpected_cfgs = { level = "warn", check-cfg = [
'cfg(use_pure_rust_but_dirty_zstd)',
'cfg(skip_fuse_atime_option)',
] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite get what this setting does ? It warns if any of these feature is used ?

Copy link
Contributor Author

@FirelightFlagboy FirelightFlagboy Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's to "register" our custom cfg, that also prevent some typo

@FirelightFlagboy FirelightFlagboy added this pull request to the merge queue Sep 19, 2024
Merged via the queue into master with commit a68801d Sep 19, 2024
15 checks passed
@FirelightFlagboy FirelightFlagboy deleted the bump-rust-toolchain branch September 19, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants