Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shiba version 1.2.1 #2217

Merged
merged 3 commits into from
Jun 3, 2019
Merged

Add Shiba version 1.2.1 #2217

merged 3 commits into from
Jun 3, 2019

Conversation

blyoa
Copy link
Contributor

@blyoa blyoa commented May 30, 2019

I added a markdown live preview app.

I did not use extract_dir because the working directory of the binary file Shiba.exe must be an actual directory instead of a symbolic link.

bucket/shiba.json Outdated Show resolved Hide resolved
Co-Authored-By: Jakub Čábera <cabera.jakub@gmail.com>
@Ash258
Copy link
Contributor

Ash258 commented Jun 3, 2019

I did not use extract_dir because the working directory of the binary file Shiba.exe must be an actual directory instead of a symbolic link.

@r15ch13 Have you tried installation and executing from current / PATH

@r15ch13
Copy link
Member

r15ch13 commented Jun 3, 2019

@Ash258 yes, I did test it and removed the extract_dir again. My fault.

Opened an issue for the symlink problem: rhysd/Shiba#52

@r15ch13 r15ch13 merged commit 132fbdd into ScoopInstaller:master Jun 3, 2019
@Ash258 Ash258 mentioned this pull request Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants