Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBGL: fix checkver #2596

Merged
merged 1 commit into from
Aug 10, 2019
Merged

DBGL: fix checkver #2596

merged 1 commit into from
Aug 10, 2019

Conversation

issaclin32
Copy link
Member

mentioned in #2308 (Outstanding Excavator issues).

Copy link
Member

@brandon93s brandon93s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checkver appears to be working, the file download of the new version is not:

dbgl: 0.83 (scoop version is 0.82) autoupdate available
Autoupdating dbgl
Downloading dbgl083.zip to compute hashes!
The remote server returned an error: (404) Not Found.
URL http://members.quicknet.nl/blankendaalr/dbgl/download/dbgl083.zip is not valid

@issaclin32
Copy link
Member Author

The checkver appears to be working, the file download of the new version is not:

The URL for v0.90 (http://members.quicknet.nl/blankendaalr/dbgl/download/dbgl082.zip) works though.

It looks like that the developer of DBGL released v0.90 (dependent on Java 8 to 12) and v0.83 (dependent on Java 7 to 8) at the same time, and put v0.83 in a different download location.

This PR modifies checkver from matching the blue box instead of the red box, so that checkver recognizes v0.90 instead of v0.83.

checkver

@rasa rasa merged commit fb0a3a2 into ScoopInstaller:master Aug 10, 2019
@issaclin32 issaclin32 deleted the patch-1 branch August 10, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants