Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ydl-ui: Update to version 2.6.2 (manually) #3125

Merged
merged 5 commits into from
Nov 8, 2019

Conversation

issaclin32
Copy link
Member

@issaclin32 issaclin32 commented Nov 6, 2019

#2308 (Outstanding Excavator issues)

  • ydl-ui changed their file name back to the original pattern. This fixes the download URL.

  • This also adds download-list.json and ydl-ui.json to persist.

  • The installer.script will modify ydl-ui.json to disable update. (if previous persist data does not exist)

Copy link
Contributor

@Ash258 Ash258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This manifest is not really portable

Persist download-list.json, ydl-ui.json and disable updates

image

@issaclin32
Copy link
Member Author

issaclin32 commented Nov 6, 2019

This manifest is not really portable

Persist download-list.json, ydl-ui.json and disable updates

Thanks for the info.

I implemented "disable update" using string replace. Not sure if it's the best approach or not.

@Ash258
Copy link
Contributor

Ash258 commented Nov 8, 2019

You could always use something like $cont = (Get-Content ...); $cont.CheckForUpdates = $false; $cont | ConvertToPrettyJson | Set-Content l..

But do not know if it is needed. Maybe for readability it could be better, cannot tell. Choose one and go with it.

@issaclin32
Copy link
Member Author

You could always use something like $cont = (Get-Content ...)

Thanks for the reply.
I will choose your approach because it is easier to expand. (when you want to add more options into the config file)

bucket/ydl-ui.json Outdated Show resolved Hide resolved
bucket/ydl-ui.json Outdated Show resolved Hide resolved
Co-Authored-By: Jakub Čábera <cabera.jakub@gmail.com>
Copy link
Contributor

@Ash258 Ash258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always run checkver as last thing before posting PR or at least save with format in vscode to prevent these inconsistencies.

bucket/ydl-ui.json Outdated Show resolved Hide resolved
Co-Authored-By: Jakub Čábera <cabera.jakub@gmail.com>
@Ash258 Ash258 merged commit d417fe3 into ScoopInstaller:master Nov 8, 2019
@issaclin32 issaclin32 deleted the fix-ydl-ui branch November 8, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants