chromium: fix #3476
Closed
chromium: fix #3476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 11, 2020 18:48
blue-cloak
suggested changes
Mar 9, 2020
| "version": "79.0.3945.117-1", | ||
| "description": "Modifications to Google Chromium for removing Google integration and enhancing privacy, control, and transparency.", | ||
| "version": "79.0.3945.117", | ||
| "description": "Modifications to Google Chromium for removing Google integration and enhancing privacy, control, and transparency (macchrome's build)", | ||
| "homepage": "https://github.com/Eloston/ungoogled-chromium", |
There was a problem hiding this comment.
Shouldn't we also change the homepage to "https://github.com/macchrome/winchrome"?
| "url": "https://github.com/macchrome/winchrome/releases/download/v$version-r$matchRev-Win64/ungoogled-chromium-$version-1_windows.7z", | ||
| "extract_dir": "ungoogled-chromium-$version-1_windows" | ||
| }, | ||
| "32bit": { |
There was a problem hiding this comment.
It seems the newest version of ungoogled-chromium has merged 32-bit version and 64-bit version.
Take this for example: https://github.com/macchrome/winchrome/releases/tag/v80.0.3987.132-r722274-Win64
There was a problem hiding this comment.
I guess the dev stop built 32 bit version for some reason.
| }, | ||
| "hash": { | ||
| "url": "https://github.com/macchrome/winchrome/releases/tag/v$version-r$matchRev-Win64", | ||
| "regex": "(?s)$basename.*?$sha1" |
There was a problem hiding this comment.
Because the merge of 32-bit version and 64-bit version, the hash autoupdate will fail for 32-bit version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3473
close #3415
#2308