obs-studio: Fix checkver #3486
Merged
obs-studio: Fix checkver #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seems like the GitHub download / releases is not the right place to go / not so reliable... because different versions are released for Window, macOS, Linux...
Ash258
suggested changes
Jan 15, 2020
There was a problem hiding this comment.
Fixed manifest
{
"version": "24.0.3",
"description": "Video recording and live streaming software",
"homepage": "https://obsproject.com",
"license": "GPL-2.0-only",
"architecture": {
"64bit": {
"url": "https://github.com/obsproject/obs-studio/releases/download/24.0.3/OBS-Studio-24.0.3-Full-x64.zip",
"hash": "69aea7d24b1b0a3bb73243c847e3c848bd970fef120808c8b26cab1ded163966",
"shortcuts": [
[
"bin\\64bit\\obs64.exe",
"OBS Studio"
]
]
},
"32bit": {
"url": "https://github.com/obsproject/obs-studio/releases/download/24.0.3/OBS-Studio-24.0.3-Full-x86.zip",
"hash": "4a6e25ca0c75012b4cf8ac6071a3a581183bc1a1c7d49f3baa4ae7710a91736a",
"shortcuts": [
[
"bin\\32bit\\obs32.exe",
"OBS Studio"
]
]
}
},
"pre_install": "if (!(Test-Path \"$persist_dir\\portable_mode.txt\")) { New-Item \"$dir\\portable_mode.txt\" | Out-Null }",
"persist": [
"config",
"portable_mode.txt"
],
"checkver": "aria-label=\"Windows\"></div><span>([\\d.]+)</span>",
"autoupdate": {
"architecture": {
"64bit": {
"url": "https://github.com/obsproject/obs-studio/releases/download/$version/OBS-Studio-$version-Full-x64.zip"
},
"32bit": {
"url": "https://github.com/obsproject/obs-studio/releases/download/$version/OBS-Studio-$version-Full-x86.zip"
}
}
}
}
|
@Ash258 beside the title change... anything else I can do? |
|
Apply changes with fixed autoupdate and minor tweaks from review summary
|
|
@AntonOks can you make the changes requested? |
Ash258
approved these changes
Jan 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2308
seems like the GitHub download / releases is not the right place to go / not so reliable... because different versions are released for Window, macOS, Linux...