Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latex: Update to version 21.8 #2784

Merged
merged 2 commits into from
Oct 21, 2021
Merged

latex: Update to version 21.8 #2784

merged 2 commits into from
Oct 21, 2021

Conversation

issaclin32
Copy link
Member

@issaclin32 issaclin32 commented Oct 20, 2021

closes #2783

@github-actions
Copy link
Contributor

Your changes do not pass checks.

latex

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@issaclin32
Copy link
Member Author

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

latex

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@issaclin32 issaclin32 changed the title latex@21.6: Fix shortcuts latex: Update to version 21.8, Fix shortcuts Oct 20, 2021
@issaclin32
Copy link
Member Author

issaclin32 commented Oct 21, 2021

@rashil2000 Requesting review. (and double-check)
I don't usually do this, but I want this to be fixed sooner. Thank you.

@rashil2000
Copy link
Member

Hey, no worries at all, just ping me when needed.

Since from 21.8 they don't provide a 32bit version, would it make sense to move the bin, shortcuts and env_add_path fields outside of the architecture block?

@issaclin32
Copy link
Member Author

issaclin32 commented Oct 21, 2021

would it make sense to move the bin, shortcuts and env_add_path fields outside of the architecture block?

This will make the manifest look cleaner,
but it looks weird when there are bin\\x64 inside the binary path.

Another way is to move all the items out of architecture -> 64-bit block, but this will make Scoop unable to stop the installation on a 32bit PC.

I personally think we can remove all the 32-bit support, since there are few 32-bit PCs in use.
However, we should keep the pattern before further discussions and decisions (from all the maintainers)

@rashil2000
Copy link
Member

Okay, then I think no further change is needed. Looks good to go!

@issaclin32 issaclin32 merged commit 37f5ff4 into master Oct 21, 2021
@issaclin32 issaclin32 deleted the issaclin32-patch-1 branch October 21, 2021 05:24
@issaclin32 issaclin32 changed the title latex: Update to version 21.8, Fix shortcuts latex: Update to version 21.8 Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

latex: shortcuts creation error
2 participants