Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Genotrance PX to latest (stable) release #459

Merged
merged 5 commits into from
Oct 4, 2019

Conversation

FredL69
Copy link

@FredL69 FredL69 commented Oct 1, 2019

This is a Pull request to update Genotrance PC the latest (stable) release.
https://github.com/genotrance/px/releases

bucket/px.json Outdated Show resolved Hide resolved
bucket/px.json Outdated Show resolved Hide resolved
Frédéric Lespez and others added 2 commits October 1, 2019 20:38
Reformat 'bin' entry as per Ash258 suggestion

Co-Authored-By: Jakub Čábera <cabera.jakub@gmail.com>
Reformat 'description' entry as per Ash258 suggestion

Co-Authored-By: Jakub Čábera <cabera.jakub@gmail.com>
@Ash258
Copy link
Contributor

Ash258 commented Oct 1, 2019

There is newer release tagged as vHead from May 20

@FredL69
Copy link
Author

FredL69 commented Oct 1, 2019

Thanks for your review.
If you prefer squashed commits, tell me so and i will rework the merge request.

@FredL69
Copy link
Author

FredL69 commented Oct 1, 2019

Sorry I didn't see your comment about the release.
Yes, there are newer releases. But they are pre-release. I aimed for the stable one.
The last one in particular is tagged vHEAD. I am afraid that the next pre-release will be tagged vHEAD and this one will be retagged with a date like all the previous pre-releases. If this happens, it will break installs done by scoop since the hash will change.

@FredL69 FredL69 requested a review from Ash258 October 1, 2019 18:58
@Ash258
Copy link
Contributor

Ash258 commented Oct 1, 2019

NOTE: Command line parameters passed with --install are not saved for use on startup. The --save flag or manual editing of px.ini is required to provide configuration to Px on startup.

https://github.com/genotrance/px#configuration

Px requires only one piece of information in order to function - the server name and port of the proxy server. This needs to be configured in px.ini.

Should be px.ini persisted??

@FredL69
Copy link
Author

FredL69 commented Oct 1, 2019

Should be px.ini persisted??

I don't know since I don't use this feature. I will look into it tomorrow and I come back to you.

@FredL69
Copy link
Author

FredL69 commented Oct 2, 2019

Should be px.ini persisted??

I looked into this issue today.
If you use the --install feature, you need to persist px.ini and px.ini should be located in the same directory as px.exe.

I tried to add a "persist": "px.ini" to the manifest, scoop tried to persist px.ini as a directory.
Is it possible to persist a file ?
Should we wait for the rework of data persistence (ScoopInstaller/Scoop#3248) ?

bucket/px.json Show resolved Hide resolved
bucket/px.json Show resolved Hide resolved
Frédéric Lespez and others added 2 commits October 2, 2019 19:43
Co-Authored-By: Jakub Čábera <cabera.jakub@gmail.com>
Persist px.ini as a file as per Ash258 suggestion.

Co-Authored-By: Jakub Čábera <cabera.jakub@gmail.com>
@FredL69
Copy link
Author

FredL69 commented Oct 2, 2019

I have tested your suggestion : it works.
Thanks a lot for your help.

@FredL69 FredL69 requested a review from Ash258 October 2, 2019 18:20
@rasa rasa merged commit 2e052b5 into ScoopInstaller:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants