neofetch: remove dependency on git installed through scoop #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently, if I don't have `git` or `git-with-openssh` installed through scoop I get a confusing error indicating `git` couldn't be found, even though it is right there on my path there are many apps that come bundled with git now, including github desktop, Cmder etc. it would be better for check for these on path as a last resort, and work out the location to `bash.exe` from there.
|
This patch is valuable, as I had to recently uninstall scoop's git, as when |
|
who can actually review it then? |
|
@xeijin Could you please fix the conflicts? I'll review it then. |
rashil2000
changed the title
|
Actually, my bad, this was already fixed in #2729 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, if I don't have
gitorgit-with-opensshinstalled through scoop I get a confusing error indicatinggitcouldn't be found, even though it is right there on my paththere are many apps that come bundled with git now, including github desktop, Cmder etc. it would be better for check for these on path as a last resort, and work out the location to
bash.exefrom there.