Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coursier: Set COURSIER_HOME #878

Merged
merged 1 commit into from
May 5, 2020
Merged

coursier: Set COURSIER_HOME #878

merged 1 commit into from
May 5, 2020

Conversation

nightscape
Copy link
Contributor

No description provided.

@Ash258
Copy link
Contributor

Ash258 commented Mar 13, 2020

  • Why?
  • Why to localappdata?

@nightscape
Copy link
Contributor Author

nightscape commented Mar 13, 2020 •
edited by Ash258
Loading

Why?

Mostly because of this SBT bug scala/scala-dev#666 and because many other packages do the same thing.

Why to LOCALAPPDATA?

That's where Coursier puts its files unless told otherwise.
I was also considering setting it to the corresponding persist folder but wasn't sure about it because it could lead to people having two Coursier caches in different locations if they e.g. first used SBT without explicitly installing Coursier via scoop (SBT bundles Coursier) and later installed Coursier in scoop.

@Ash258 Ash258 requested a review from a team March 18, 2020 21:07
@r15ch13 r15ch13 merged commit 2621087 into ScoopInstaller:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasa rasa rasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nightscape @Ash258 @rasa @r15ch13