Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ps1 shims for git are reseting $? PowerShell variable #3890

Closed
Demivan opened this issue Mar 23, 2020 · 2 comments
Closed

ps1 shims for git are reseting $? PowerShell variable #3890

Demivan opened this issue Mar 23, 2020 · 2 comments

Comments

@Demivan
Copy link

Demivan commented Mar 23, 2020

Shims for git package are breaking GitLab runner. When runner tries to fetch git repo it checks for exit code of git but shims are resetting $? variable.
So even if git command fails $? will report no error.
Ash258 added a commit to Ash258/Scoop-Core that referenced this issue Jul 25, 2020
@Ash258
fix(shims): Always exit $LASTEXITCODE from ps1 shim
b0e89ea 
ScoopInstaller#3890

![A](https://i.imgur.com/K9uAZXm.png)
@Ash258 Ash258 mentioned this issue Aug 1, 2020
Closed
@AndrewSav
Copy link

It's not just for git. Many other shims do that too, which is not surprising, since it's the same basic shim...

@Ash258 Ash258 mentioned this issue Aug 27, 2020
Open
@rashil2000 rashil2000 mentioned this issue Nov 28, 2021
Merged
@rashil2000
Copy link
Member

Merged in develop branch - #4543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AndrewSav @Demivan @rashil2000