Fix VirusTotal results querying: switch to v3 API and offer links to manually check when things fail #4130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrama
force-pushed
the
virustotal-exception-handling
branch
from
fa5fea2 to
eacb00e
Compare
pcrama
changed the title
pcrama
force-pushed
the
virustotal-exception-handling
branch
from
eacb00e to
ce04fca
Compare
|
I am aware that the AppVeyor checks failed, but I don't see the file I have edited |
pcrama
force-pushed
the
virustotal-exception-handling
branch
from
613fa63 to
042feb5
Compare
21 tasks
|
Superceded by #4983 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virustotal started reporting 429 HTTP errors (related to captchas)
Instead of just reporting an error, provide the URL so that the user may easily check for themselves (especially if their terminal allows clicking URLs).
To avoid the 429 HTTP errors, I also upgraded the querying of the VirusTotal to use their v3 REST API when the API key is configured. This is much more reliable than the old way.