Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shim): Fix #4728 #4767

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(shim): Fix #4728 #4767

wants to merge 1 commit into from

Conversation

vieiraa
Copy link

@vieiraa vieiraa commented Feb 28, 2022 •
edited
Loading

Description

See 71/scoop-better-shimexe#13 and kiennq/scoop-better-shimexe#2. Added fix for when there is a space in the path.

Motivation and Context

Fixes #4728

How Has This Been Tested?

Replace executable, then run

scoop reset *

@vieiraa vieiraa changed the title Add fix for 'Could not create process with command' fix(shim): Fix #4728 Feb 28, 2022
@vieiraa vieiraa mentioned this pull request Feb 28, 2022
Closed
@rashil2000
Copy link
Member

We have actually switched to using the kiennq shim, because of 71/scoop-better-shimexe#9 and other performance reasons. You can check the discussion here #3634 and here #4333.

Can you make the same PR in https://github.com/kiennq/scoop-better-shimexe?

@vieiraa
Copy link
Author

vieiraa commented Mar 1, 2022 •
edited
Loading

Done. See kiennq/scoop-better-shimexe#2. Will create a new executable when they merge the PR.

@rashil2000
Copy link
Member

When it's done, please create the PR from 'develop' branch

chawyehsu
chawyehsu reviewed Mar 1, 2022
View reviewed changes
Copy link
Member

@chawyehsu chawyehsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScoopInstaller/maintainers a reminder of binary commits.
https://github.com/orgs/ScoopInstaller/teams/maintainers/discussions/6

@vieiraa
Copy link
Author

vieiraa commented Mar 1, 2022

@ScoopInstaller/maintainers a reminder of binary commits. https://github.com/orgs/ScoopInstaller/teams/maintainers/discussions/6

I can't access this link. Should I be aware of something?

@vieiraa vieiraa changed the base branch from master to develop March 1, 2022 16:05
@rashil2000
Copy link
Member

It's basically a discussion about creating binaries transparently and distributing them via the https://github.com/ScoopInstaller/Shim repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chawyehsu chawyehsu chawyehsu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Shims fail if path contains spaces
3 participants
@vieiraa @rashil2000 @chawyehsu