-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand the scope of the naming convention regex #32
Comments
I'm open to this and it's an easy change, but I first want to better understand when you'd use this naming convention with the BTT approach? I'd love to see an example of a sample tree and resulting test name (for both the given and when cases) to help get on the same page |
Thanks! and sure. There are many examples in V2 Core that intersperse And then see the |
Just noting that v0.0.19 has been released with this feature! |
I'm not sure if this is the best place to post this feature request, but based on a recent discussion in Sablier V2 Core (ref sablier-labs/v2-core#647), we decided to start using the following test function name:
So I would like the naming convention regex to be expanded to allow for both
RevertGiven
andRevertWhen
. WDYT? I think that the regex is already flexible insofar as it supportsRevertIf
.The goal is to mirror the
Given
keyword in Solidity (we started usingGiven
in the branching trees).The text was updated successfully, but these errors were encountered: