Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the scope of the naming convention regex #32

Closed
PaulRBerg opened this issue Aug 9, 2023 · 3 comments · Fixed by #33
Closed

Expand the scope of the naming convention regex #32

PaulRBerg opened this issue Aug 9, 2023 · 3 comments · Fixed by #33

Comments

@PaulRBerg
Copy link

I'm not sure if this is the best place to post this feature request, but based on a recent discussion in Sablier V2 Core (ref sablier-labs/v2-core#647), we decided to start using the following test function name:

test_RevertGiven_Something

So I would like the naming convention regex to be expanded to allow for both RevertGiven and RevertWhen. WDYT? I think that the regex is already flexible insofar as it supports RevertIf.

The goal is to mirror the Given keyword in Solidity (we started using Given in the branching trees).

@mds1
Copy link
Contributor

mds1 commented Aug 30, 2023

I'm open to this and it's an easy change, but I first want to better understand when you'd use this naming convention with the BTT approach? I'd love to see an example of a sample tree and resulting test name (for both the given and when cases) to help get on the same page

@PaulRBerg
Copy link
Author

PaulRBerg commented Aug 30, 2023

@mds1
Copy link
Contributor

mds1 commented Sep 5, 2023

Just noting that v0.0.19 has been released with this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants