Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update deps, allow RevertGiven, stricter test naming checks #33

Merged
merged 6 commits into from
Sep 5, 2023

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Sep 1, 2023

Closes #32.

  • Updates dependencies
  • Allows RevertGiven as an additional allowed name
  • Parses test names by splitting them at underscores to be stricter about disallowing certain names. This is required because the regex crate does not support Îlook-aheads, which are required to restrict things like test_RevertIfCondition

@PaulRBerg would love if you could give this a test

Copy link

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the two comments below.

Thanks for this

src/check/validators/test_names.rs Show resolved Hide resolved
src/check/validators/test_names.rs Show resolved Hide resolved
@mds1 mds1 merged commit 76c8f01 into main Sep 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand the scope of the naming convention regex
3 participants