Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem matchers #7

Merged
merged 5 commits into from
Dec 25, 2019
Merged

Conversation

softprops
Copy link
Contributor

This change takes advantage of a built-in GitHub actions feature for inlining errors based on a problem matchers definition.

Note because this is a docker image based actions there was one quirk involved to make this work. actions/toolkit#56 (comment)

@ScottBrenner ScottBrenner added the enhancement New feature or request label Dec 25, 2019
Copy link
Owner

@ScottBrenner ScottBrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! 👍

@ScottBrenner ScottBrenner merged commit 4e7c712 into ScottBrenner:master Dec 25, 2019
@softprops
Copy link
Contributor Author

Not sure if you saw it but I opened an issue to see if you could publish these to docker hub. It saves a significant amount of time rebuilding the docker image before it can be run on each workflow run.

I can post a PR to add that but your have to create the secret and docker hub repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants