Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFD-135 Set up workflow to run when merging PR's #108

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

jmain-scottlogic
Copy link
Collaborator

SFD-135

  • Change pull-request workflow to build and test.
  • Update so runs when PR's merged into main
  • Removed playwright workflow as covered by build and test
  • Update test step in pages to run build and test workflow

Copy link
Collaborator

@mgriffin-scottlogic mgriffin-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also need to change publish-package.yml as this calls the old pull-request.yml workflow as well. Not sure exactly what happens when a workflow is called twice as this calls the page publish too, will have to see if it does something sensible or builds and tests things twice.

@jmain-scottlogic
Copy link
Collaborator Author

Updated publish to point at build-and-test. Quickly looking into making the build-and-test step optional, but hit problem as github workflows don't seem to support conditional needs

Copy link
Collaborator

@mgriffin-scottlogic mgriffin-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, yeah Github Actions never seems to make it easy. There's some things you can do with conditionals but a lot of stuff is very easy to break and not know about it until things just don't run.

@jmain-scottlogic jmain-scottlogic merged commit 553a0e2 into main Jul 11, 2024
3 checks passed
@jmain-scottlogic jmain-scottlogic deleted the SFD-135-merging-workflow branch July 11, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants