SFD-127: Add tooltip to calculate button when its disabled #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/app/carbon-estimator-form/carbon-estimator-form.component.html
Outdated
Show resolved
Hide resolved
# Conflicts: # src/app/carbon-estimator-form/carbon-estimator-form.component.html
mgriffin-scottlogic
previously approved these changes
Jun 26, 2024
This will be added in a separate PR.
mgriffin-scottlogic
approved these changes
Jun 28, 2024
mgriffin-scottlogic
deleted the
SFD-127-disabled-calculate-button-message
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SFD-127 Jira ticket
Adds a message under the calculate button when its disabled to explain which fields are invalid
With one error:
Multiple errors:
I think getting the text all the way to the right as in the one error case when the text wraps with multiple errors might require some JavaScript so I've left it like this for now. (Commas and full stops for the list of errors also omitted for now since I think that may also require some JavaScript including adding some logic to check which fields are invalid to the component.) Maybe just having it always be left aligned would be better.
At the moment its set up to always display the message when the form is invalid (as long as it's been interacted with) rather than being like a tooltip that is only visible when the calculate button is focussed. I thought that might work a bit better if we include links to the invalid fields but we could try other approaches.