Add a custom time period over which to calculate the temperature derivative. #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a parameter
period_for_derivative_calculationthat uses the last 1h (by default) to calculate the derivative value. I developed this for myself as my thermostat is sending readings every 2s which made the default derivative quite meaningless due to noise in the temp measurement. I tried playing around withsampling_periodbut I did not find it to my satisfaction.Please have a look and let me know if you think we should add this. I can add a toggle to make this behavior optional, but I will only do that and add the documentation if you think we should go ahead with this.
I've been using this with my water floor heating for the past 2 winters and it worked nicely.