Skip to content
This repository has been archived by the owner on Jan 21, 2021. It is now read-only.

Make the JavaScript code cleaner and reusable #30

Open
moeenio opened this issue Oct 10, 2020 · 11 comments
Open

Make the JavaScript code cleaner and reusable #30

moeenio opened this issue Oct 10, 2020 · 11 comments
Labels
enhancement New feature or request priority--2 Medium priority

Comments

@moeenio
Copy link
Member

moeenio commented Oct 10, 2020

I'm okay with going no-framework (#11), but then we should make the JS code cleaner and reusable, using classes and all that stuff. These would be split into multiple files.

@moeenio moeenio added enhancement New feature or request priority--2 Medium priority labels Oct 10, 2020
@moeenio

This comment has been minimized.

@micahlt
Copy link
Member

micahlt commented Oct 19, 2020

@locness3 What exactly do you mean by classes? I'm all for cleaning up (and documenting) the JavaScript.

@moeenio
Copy link
Member Author

moeenio commented Oct 19, 2020

@micahlt
Copy link
Member

micahlt commented Oct 29, 2020

I've modularized the JS as much as I feel is necessary in 272d5ba.

@moeenio
Copy link
Member Author

moeenio commented Oct 29, 2020

Pretty nice already.

@micahlt
Copy link
Member

micahlt commented Oct 29, 2020

Thanks :)

@moeenio
Copy link
Member Author

moeenio commented Oct 30, 2020

Now I think we should :

  1. Use the class IdkWhat and import IdkWhat from "file.js" syntaxes, that Parcel allows us to use.
  2. Adopt a design pattern such as Model-View-Controller.

@moeenio
Copy link
Member Author

moeenio commented Oct 31, 2020

Also, I suggest once again that we use lit-html.

@moeenio
Copy link
Member Author

moeenio commented Nov 6, 2020

...hi?

@micahlt
Copy link
Member

micahlt commented Nov 6, 2020 via email

@moeenio
Copy link
Member Author

moeenio commented Nov 6, 2020

Okay, I'll try to give some time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request priority--2 Medium priority
Projects
None yet
Development

No branches or pull requests

2 participants