Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to docs/installing, including Firefox for Android #453

Merged
merged 14 commits into from
Aug 2, 2024

Conversation

Samq64
Copy link
Member

@Samq64 Samq64 commented Jun 4, 2024

This might still need some work. The installation process is not very user-friendly and tricky to explain.

@Samq64 Samq64 added the scope: docs Related to the documentation (Scratch Addons Docs) label Jun 4, 2024
@WorldLanguages
Copy link
Member

There's a few typos

@WorldLanguages
Copy link
Member

I still think we could do better on this page, the normal install button for average users can only be found in the navbar.

Maybe we could add big Chrome Web Store and Firefox Addons images just like the extension repo Readme 🤔

I know this is off topic

@Samq64
Copy link
Member Author

Samq64 commented Jun 9, 2024

Maybe we could add big Chrome Web Store and Firefox Addons images just like the extension repo Readme 🤔

I stuck them at the top of the page.

content/docs/getting-started/installing.md Outdated Show resolved Hide resolved
content/docs/getting-started/installing.md Show resolved Hide resolved
@Samq64
Copy link
Member Author

Samq64 commented Jun 17, 2024

I made some more changes. Do you still approve?

@Samq64 Samq64 changed the title Android Firefox dev installation instructions Better Firefox installation instructions + Firefox for Android Jun 19, 2024
@WorldLanguages
Copy link
Member

I still don't see the motivation of using web-ext. What's the benefit?

@Samq64
Copy link
Member Author

Samq64 commented Jun 21, 2024

I still don't see the motivation of using web-ext. What's the benefit?

Mainly that it keeps the extension settings separate from the store release. It also seems to solve the CSS caching issues but I could be wrong.

@hueychen27
Copy link

hueychen27 commented Jun 24, 2024

I still don't see the motivation of using web-ext. What's the benefit?

I should have mentioned this, so now I will.
The top 3 benefits:

  1. It is a convenient tool used for extension development as it automatically loads the extension to a browser with one command. This means that web-ext is a much improved way of loading an extension with about:debugging.
  2. It has features like auto-reloading and linting. Auto-reloading is useful not directly in the webpage but in the extension popup and background services.
  3. web-ext creates isolation from the main browser profile by creating a temporary one.

@Samq64
Copy link
Member Author

Samq64 commented Jul 11, 2024

I reverted the web-ext instructions for desktop. It can be PRed separately.

@WorldLanguages WorldLanguages merged commit 138401e into ScratchAddons:master Aug 2, 2024
4 checks passed
@Samq64 Samq64 deleted the firefox-android-installl branch August 3, 2024 00:20
@hueychen27
Copy link

@Samq64 Title change for this pr

@WorldLanguages WorldLanguages changed the title Better Firefox installation instructions + Firefox for Android Changes to docs/installing, including Firefox for Android Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs Related to the documentation (Scratch Addons Docs)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants