Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schedule ending at midnight and wrong rain status if plugin started when wet #11

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

mookkari
Copy link
Contributor

@mookkari mookkari commented Aug 2, 2024

Fixes:

  • When the schedule ended at midnight ("endAt": "24:00:00") UpdateFromMqtt changed 24:00 to 00:00 meaning that the date's schedule was removed in the next set_schedule call.
  • rainStatusCode will be read in InitValues. If the plugin was initialized when it is wet it was showing default status value "Dry" until the rain status was updated from mqtt. It seems like Mqtt will update the rain status only when it is changed, so it might take hours (or days?) to get the correct status when it's raining for a long time.
  • Modified documentation with examples of schedule ending at midnight.

Fixes:
- When schedule ended at midnight ("endAt": "24:00:00"), UpdateFromMqtt changed 24:00 to 00:00 meaning that dated schedule was basically removed in next set_schedule call.
- rainStatusCode will be read in InitValues. If plugin was initialized when it's wet is was showing default Dry status until rain status was updated from mqtt. Mqtt will update rain status only when status is changed so it might take hours (or days?) to get correct status when it's raining all day long.
@Sdahl1234 Sdahl1234 merged commit 71f3873 into Sdahl1234:main Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants