-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Expr::asterisk() and Expr::tbl_asterisk(table: DynIden) methods - Fix #217 #219
Conversation
src/types.rs
Outdated
Wildcard, | ||
TableWildcard(DynIden) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@billy1624 how will this affect SeaORM / SeaSchema?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No impact for SeaSchema. But this part of code has to be updated in SeaORM.
https://github.com/SeaQL/sea-orm/blob/82bad4a376efb875ac32ab601ac2cd9cce191e3f/src/query/combine.rs#L45-L62
Thank you for the contribution! Looks good all-in-all. Sorry for the name argument. |
Yeah, no problem for the name: I call I'll rename all the appellation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
This fix #217, adding two new methods:
Expr::wildcard()
Expr::tbl_wildcard(table: DynIden)