Introduce dynamic query/schema builder factory method #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitnelave
commented
Jun 26, 2022
| let connection = AnyPool::connect(url).await.unwrap(); | ||
| let mut pool = connection.try_acquire().unwrap(); | ||
| let box_query_builder = query_builder_from_kind(pool.kind()); |
There was a problem hiding this comment.
The interesting scenario here is to read the DB address from command-line, env or a config file, and as long as it's valid (connection was successful), build a query builder from whatever it resolved to.
ikrivosheev
reviewed
Jun 26, 2022
|
Since the PR targets sqlx 0.5 (which you are still using) I can only merge that into 0.25.x. master now only targets sqlx 0.6. Would appreciate that you open a PR on that when you upgraded. |
|
Thanks, opened #371.
…On Fri, Jul 1, 2022 at 2:33 PM Chris Tsang ***@***.***> wrote:
Since the PR targets sqlx 0.5 (which you are still using) I can only merge
that into 0.25.x. master now only targets sqlx 0.6. Would appreciate that
you open a PR on that when you upgraded.
—
Reply to this email directly, view it on GitHub
<#362 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGCPWP42GTHQBS5NLZH3JLVR3QSJANCNFSM5Z3TTK4Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Valentin Tolmer
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
Follow-up of #275 to clean up the interface, using launchbadge/sqlx#1228.
Adds
sea_query_binder::query_builder_from_kindto get a query builder from a dynamic SQLX DB connection.sea_query_binder::schema_builder_from_kindsame for schema.Breaking Changes