Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-30632: Added the submodule dispatch event #160

Merged
merged 3 commits into from
May 15, 2022
Merged

Conversation

venkuppu-chn
Copy link

@venkuppu-chn venkuppu-chn commented Apr 11, 2022

Problem :
Commit hash of cortx-rgw is static at cortx repository and has to be updated manually which is quite tedious to do for every commit.

Solution :
Added the Github action workflow which will dispatch the event with latest commit hash of cortx-rgw to parent cortx repo.

Signed-off-by: Venkatesh K venkatesh.k@seagate.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

Signed-off-by: Venkatesh K <venkatesh.k@seagate.com>
Signed-off-by: Venkatesh K <venkatesh.k@seagate.com>
Copy link

@mukul-seagate11 mukul-seagate11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@andriytk
Copy link

Problem : There is no submodule found in parent repo for cortx-rgw

Sorry, I cannot get it. Which submodule and why it is a problem?

@mukul-seagate11
Copy link

Problem : There is no submodule found in parent repo for cortx-rgw

Sorry, I cannot get it. Which submodule and why it is a problem?

@andriytk, This PR is to create linking of submodule as cortx-rgw in parent repo i.e. https://github.com/Seagate/cortx

@andriytk
Copy link

andriytk commented Apr 13, 2022

@andriytk, This PR is to create linking of submodule as cortx-rgw in parent repo i.e. https://github.com/Seagate/cortx

Please, update the PR description with this information. And please elaborate - why is this linking needed, what is it for. Thanks.

@venkuppu-chn
Copy link
Author

venkuppu-chn commented Apr 13, 2022

@andriytk, This PR is to create linking of submodule as cortx-rgw in parent repo i.e. https://github.com/Seagate/cortx

Please, update the PR description with this information. And please elaborate - why is this linking needed, what is it for. Thanks.

Updated, they are a quick visual indicator to the community where else they can other software relevant to cortx.

@mukul-seagate11
Copy link

@Gatekeepers, please merge the PR as already approved

@hessio hessio added Patrick Assigned to Patrick Status: Waiting for Review PR is waiting for approval Status: Waiting to be Merged PR has been approved and now is waiting to be merged and removed Status: Waiting for Review PR is waiting for approval labels Apr 28, 2022
@sachinpunadikar sachinpunadikar merged commit a2ab7aa into main May 15, 2022
@sachinpunadikar sachinpunadikar deleted the submodule branch May 15, 2022 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI Patrick Assigned to Patrick Status: Waiting to be Merged PR has been approved and now is waiting to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants