Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #greaseAsByteArray and implementation for Squeak #161

Merged
merged 15 commits into from
Nov 4, 2023

Conversation

theseion
Copy link
Member

@theseion theseion commented Oct 29, 2023

Add #asGreaseByteArray as compatibility method for Collection and Integer #asByteArray methods. #asByteArray does not exist on integer classes in Squeak and GemStone.

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05a6c4e) 84.57% compared to head (f7d9822) 84.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
+ Coverage   84.57%   84.83%   +0.25%     
==========================================
  Files        2017     2045      +28     
  Lines       13558    13790     +232     
==========================================
+ Hits        11467    11699     +232     
  Misses       2091     2091              
Files Coverage Δ
...Collection.extension/instance/greaseAsByteArray.st 100.00% <100.00%> (ø)
...e/GRPlatform.class/instance/integerAsByteArray..st 100.00% <100.00%> (ø)
...ge/Integer.extension/instance/greaseAsByteArray.st 100.00% <100.00%> (ø)
...e/LargeInteger.extension/instance/greaseByteAt..st 100.00% <100.00%> (ø)
...argeInteger.extension/instance/greaseBytesCount.st 100.00% <100.00%> (ø)
...e/SmallInteger.extension/instance/greaseByteAt..st 100.00% <100.00%> (ø)
...mallInteger.extension/instance/greaseBytesCount.st 100.00% <100.00%> (ø)
...e/LargeInteger.extension/instance/greaseByteAt..st 100.00% <100.00%> (ø)
...argeInteger.extension/instance/greaseBytesCount.st 100.00% <100.00%> (ø)
...e/SmallInteger.extension/instance/greaseByteAt..st 100.00% <100.00%> (ø)
... and 20 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theseion
Copy link
Member Author

@jbrichau I don't have GemStone. Could you add the necessary things for GemStone to this PR?

@jbrichau
Copy link
Member

It turns out GLASS does include Integer>>asByteArray (https://github.com/glassdb/glass/blob/master/repository/Squeak.v36.package/Integer.extension/instance/asByteArray.st)

@theseion I added the missing methods for GemStone.

Copy link
Member

@jbrichau jbrichau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@jbrichau jbrichau merged commit 3a4e4bc into SeasideSt:master Nov 4, 2023
@theseion theseion deleted the add-integer-greaseasbytearray branch November 4, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants