-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add #greaseAsByteArray and implementation for Squeak #161
Add #greaseAsByteArray and implementation for Squeak #161
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
==========================================
+ Coverage 84.57% 84.83% +0.25%
==========================================
Files 2017 2045 +28
Lines 13558 13790 +232
==========================================
+ Hits 11467 11699 +232
Misses 2091 2091
☔ View full report in Codecov by Sentry. |
@jbrichau I don't have GemStone. Could you add the necessary things for GemStone to this PR? |
Move extensions from LargeInteger to LargePositiveInteger
Move extensions from LargeInteger to LargePositiveInteger
…>>greaseByteCount on SmallInteger and LargeInteger
It turns out GLASS does include @theseion I added the missing methods for GemStone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
Add
#asGreaseByteArray
as compatibility method forCollection
andInteger
#asByteArray
methods.#asByteArray
does not exist on integer classes in Squeak and GemStone.