Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slime renovation #167

Merged
merged 21 commits into from
Jan 14, 2024
Merged

Slime renovation #167

merged 21 commits into from
Jan 14, 2024

Conversation

jbrichau
Copy link
Member

@jbrichau jbrichau commented Jan 13, 2024

Slime rules for Pharo 11 and higher:

  • Removed obsolete rules:
    • GREmptyStatementRule is superseded in Pharo by ReMultiplePeriodsTerminatingStatementRule
    • Literal byte arrays are now supported across all supported dialects, so we removed this rule
  • Ported implementation to Renraku critiques framework
  • Improvements to rules to show critiques in the code browser

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Attention: 106 lines in your changes are missing coverage. Please review.

Comparison is base (b0307c4) 84.75% compared to head (4e5cec2) 84.96%.

Files Patch % Lines
...RTestAssertionsRule.class/instance/checkMethod..st 0.00% 7 Missing ⚠️
....package/GRReSlimeTest.class/instance/canParse..st 0.00% 7 Missing ⚠️
...package/GRAnsiBooleansRule.class/instance/group.st 0.00% 4 Missing ⚠️
...ckage/GRAnsiCharactersRule.class/instance/group.st 0.00% 4 Missing ⚠️
...kage/GRAnsiCollectionsRule.class/instance/group.st 0.00% 4 Missing ⚠️
...age/GRAnsiConditionalsRule.class/instance/group.st 0.00% 4 Missing ⚠️
...ackage/GRAnsiConvertorRule.class/instance/group.st 0.00% 4 Missing ⚠️
...ckage/GRAnsiExceptionsRule.class/instance/group.st 0.00% 4 Missing ⚠️
....package/GRAnsiStreamsRule.class/instance/group.st 0.00% 4 Missing ⚠️
....package/GRAnsiStringsRule.class/instance/group.st 0.00% 4 Missing ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   84.75%   84.96%   +0.21%     
==========================================
  Files        1923     2038     +115     
  Lines       13092    13983     +891     
==========================================
+ Hits        11096    11881     +785     
- Misses       1996     2102     +106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant