Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port Seaside to 3.7.0 #1248

Closed
dalehenrich opened this issue Mar 27, 2021 · 2 comments · Fixed by #1249
Closed

port Seaside to 3.7.0 #1248

dalehenrich opened this issue Mar 27, 2021 · 2 comments · Fixed by #1249
Assignees
Labels

Comments

@dalehenrich
Copy link
Member

initial Seaside test runs against 3.7.0 have quite a few failures:

**************************************************************************************
	Results for Seaside3 tests
1447 run, 1304 passes, 0 expected defects, 128 failures, 15 errors, 0 unexpected passes
**************************************************************************************

failures likely due to a change to one of the fundamental GemStone methods ... the handling of breakpoints has changed, which was the source of GLASS failures, but the GLASS tests are running clean at this point ...

@dalehenrich dalehenrich self-assigned this Mar 27, 2021
@dalehenrich
Copy link
Member Author

main problem was I needed to add 3.7.0 to baseline, but a new release of gsApplicationTools was needed to fix some real 3.7.0 issues

@dalehenrich
Copy link
Member Author

additional changes have been made to GemStone 3.7.0, so reopening.

In GemStone 3.7.0, ReadByteStream (an optimized version of ReadStreamPortable) is now returned as a result of the #readStream method (formerly AnsiReadStream), so ReadByteStream>>seasideMimeDocument needs to be implemented (see SeasideSt/Grease#129 for related changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants