Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for Issue #1115 #1116

Merged
merged 4 commits into from
Mar 18, 2019
Merged

fix for Issue #1115 #1116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c0f414
Issue #1115: add #SentButNotImplementedTest and #UndefinedSymbolsTes…
dalehenrich Mar 15, 2019
1f7c36b
Issue #1115: typo in .smalltalk.ston
dalehenrich Mar 15, 2019
a30f4ba
Issue #1115: missing }, not missing , .. I think
dalehenrich Mar 15, 2019
99503f8
Issue #1115: proposed fix
dalehenrich Mar 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .smalltalk.ston
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ SmalltalkCISpec {
#testing : {
#exclude : {
#packages : [ 'Cryptography.*' ]
}
}
},
#include : {
#classes : [ #SentButNotImplementedTest , #UndefinedSymbolsTest ]
}
}
}
7 changes: 2 additions & 5 deletions ...de-Adaptors-FastCGI.package/WAFastCGIAdaptor.class/instance/addCookieRFC2965.toStream..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
private
addCookieRFC2965: aWACookie toStream: aStream
"https://github.com/SeasideSt/Seaside/issues/1115"

aStream
nextPutAll: 'Set-Cookie: ';
nextPutAll: aWACookie rfc2965String;
nextPut: Character cr;
nextPut: Character lf.
self addCookieRFC6265: aWACookie toStream: aStream
7 changes: 7 additions & 0 deletions ...de-Adaptors-FastCGI.package/WAFastCGIAdaptor.class/instance/addCookieRFC6265.toStream..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
private
addCookieRFC6265: aWACookie toStream: aStream
aStream
nextPutAll: 'Set-Cookie: ';
nextPutAll: aWACookie rfc6265String;
nextPut: Character cr;
nextPut: Character lf
4 changes: 2 additions & 2 deletions repository/Seaside-Core.package/WACookie.class/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ Cookie spec
http://tools.ietf.org/html/rfc2109

Cookie 2 spec
http://tools.ietf.org/html/rfc2965
https://tools.ietf.org/html/rfc6265

HttpOnly
http://msdn2.microsoft.com/en-us/library/ms533046.aspx
https://bugzilla.mozilla.org/show_bug.cgi?id=178993

Compared to WARequestCookie I represent the information that is sent to the user agent.
Compared to WARequestCookie I represent the information that is sent to the user agent.