WaBuilder should be able to render on arbitrary stream #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new method takes a stream as argument, which enables rendering on the response stream, for example. #render: now dispatches to #render:on:
gcotelli
approved these changes
Jun 22, 2019
jecisc
approved these changes
Jun 22, 2019
|
@jbrichau Should this go in develop or master? When you want to switch to a master only contributions, it would be good to update the contribution guide. |
|
@jecisc Let's keep it on develop. I can check to merge develop to master after verifying what is actually pending. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.