Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to multiple value headers convertion #1211 #1212

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Fixes to multiple value headers convertion #1211 #1212

merged 1 commit into from
Jul 16, 2020

Conversation

eMaringolo
Copy link
Contributor

Fixes #1211

@jbrichau
Copy link
Member

Hey @eMaringolo
Thanks for the fix!

I think a small test to prevent regression in the future would be a good idea as well. However, it appears we do not have a test package for the Zinc adaptor, so I registered #1213

@eMaringolo
Copy link
Contributor Author

Yes, I noticed that the adaptor had no test case, and that's why I went straight and submitted the proposed fix.

Are these fixes backported somehow to previous releases? (e.g. Seaside 3.3 or 3.2)

@jbrichau jbrichau merged commit b96c12d into SeasideSt:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrichau jbrichau jbrichau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple value Headers only set the latest one when converting a WAResponse to ZnResponse
2 participants
@eMaringolo @jbrichau