Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the GsContext class because it is in Grease since 2 years now #1227

Merged
merged 3 commits into from
Oct 2, 2020
Merged

Removed the GsContext class because it is in Grease since 2 years now #1227

merged 3 commits into from
Oct 2, 2020

Conversation

jbrichau
Copy link
Member

@jbrichau jbrichau commented Oct 2, 2020

Fix for #1223

dalehenrich
dalehenrich previously approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@dalehenrich dalehenrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@jbrichau
Copy link
Member Author

jbrichau commented Oct 2, 2020

@dalehenrich github is not so friendly to a reviewer when new pushes get added :-) I did not dismiss anything. Seems like that happens automatically.

Anyway, a test is failing due to some Duration bug in Pharo.. so I adapted the test to work around that.

@jbrichau jbrichau merged commit eb18dd6 into master Oct 2, 2020
@jbrichau jbrichau deleted the remove-gscontext branch October 2, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalehenrich dalehenrich dalehenrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrichau @dalehenrich