Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt tests to changes in chromedriver and Parasol #1268

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Adapt tests to changes in chromedriver and Parasol #1268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...de-Tests-Parasol.package/WAWebDriverFunctionalTestCase.class/instance/expectedFailures.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
running
expectedFailures
| todo temporaryDisabled |
"temporarydisabled due to chromedriver bug https://bugs.chromium.org/p/chromium/issues/detail?id=1205107"
temporaryDisabled := #(testButtonFunctionalTest testCanvasTagFunctionalTest).
| todo |
todo := #(testExceptionFunctionalTest testExpiryFunctionalTest testFilterFunctionalTest testFlowErrorFunctionalTest).
^ temporaryDisabled, ((GRPlatform current class == (Smalltalk at: #GRGemStonePlatform ifAbsent:[ nil ]))
^ ((GRPlatform current class == (Smalltalk at: #GRGemStonePlatform ifAbsent:[ nil ]))
ifTrue: [ #(testContextFunctionalTest), todo "requires https://github.com/GsDevKit/Grease/pull/17 to be merged" ]
ifFalse:[ todo ])
8 changes: 4 additions & 4 deletions ...-Parasol.package/WAWebDriverFunctionalTestCase.class/instance/testButtonFunctionalTest.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,19 @@ testButtonFunctionalTest
self assert: (driver findElementByTagName: 'td') getText equals: 'a textAt the Seaside!'.

"Push reset"
self assert: ((driver findElementByCSSSelector: 'input[type=text]') getAttribute:'value') equals: 'a textAt the Seaside!'.
self assert: ((driver findElementByCSSSelector: 'input[type=text]') getProperty: 'value') equals: 'a textAt the Seaside!'.
(driver findElementByCSSSelector: 'input[type=text]') click.
driver getKeyboard sendKeys: 'blabla'.
self assert: ((driver findElementByCSSSelector: 'input[type=text]') getAttribute:'value') ~= 'a textAt the Seaside!'.
self assert: ((driver findElementByCSSSelector: 'input[type=text]') getProperty: 'value') ~= 'a textAt the Seaside!'.
(driver findElementByCSSSelector: 'button[type=reset]') click.
self assert: ((driver findElementByCSSSelector: 'input[type=text]') getAttribute:'value') equals: 'a textAt the Seaside!'.

"Push push"
(driver findElementByCSSSelector: 'input[type=text]') click.
driver getKeyboard sendKeys: 'blabla'.
inputValue := (driver findElementByCSSSelector: 'input[type=text]') getAttribute:'value'.
inputValue := (driver findElementByCSSSelector: 'input[type=text]') getProperty: 'value'.
textValue := (driver findElementByTagName: 'td') getText.
self assert: (inputValue ~= textValue).
(driver findElementByCSSSelector: 'button[type=button]') click.
self assert: ((driver findElementByCSSSelector: 'input[type=text]') getAttribute:'value') equals: inputValue.
self assert: ((driver findElementByCSSSelector: 'input[type=text]') getProperty: 'value') equals: inputValue.
self assert: (driver findElementByTagName: 'td') getText equals: textValue
2 changes: 1 addition & 1 deletion ...rasol.package/WAWebDriverFunctionalTestCase.class/instance/testCanvasTagFunctionalTest.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ testCanvasTagFunctionalTest
self selectTest: 'WACanvasTagTest'.
"Can only test if this does not crash"
driver findElementByID: #tutorial.
self assert: ((driver findElementsByTagName: 'script') anySatisfy: [ :script | (script getAttribute: 'innerHTML') = 'drawShape()' ]).
self assert: ((driver findElementsByTagName: 'script') anySatisfy: [ :script | (script getProperty: 'innerHTML') = 'drawShape()' ]).