Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out subclass creation #1425

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Factor out subclass creation #1425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...Pharo-Welcome.package/GRPharoPlatform.extension/instance/subclassOf.named.categorized..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
*Seaside-Pharo-Welcome
subclassOf: aSuperClass named: aNameSymbol categorized: aCategoryString
^ (aSuperClass respondsTo: #<<)
ifTrue: [
aSuperClass << aNameSymbol
package: aCategoryString;
install ]
ifFalse: [
super
subclassOf: aSuperClass
named: aNameSymbol
categorized: aCategoryString ]
2 changes: 1 addition & 1 deletion repository/Seaside-Pharo-Welcome.package/monticello.meta/categories.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
SystemOrganization addCategory: #'Seaside-Pharo-Welcome'!
self packageOrganizer ensurePackage: #'Seaside-Pharo-Welcome' withTags: #()!
8 changes: 8 additions & 0 deletions ...ry/Seaside-Welcome.package/GRPlatform.extension/instance/subclassOf.named.categorized..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
*Seaside-Welcome
subclassOf: aSuperClass named: aNameSymbol categorized: aCategoryString
^ aSuperClass
subclass: aNameSymbol
instanceVariableNames: ''
classVariableNames: ''
poolDictionaries: ''
category: aCategoryString
10 changes: 4 additions & 6 deletions ...tory/Seaside-Welcome.package/WAWelcomeComponentCreator.class/instance/createComponent..st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,10 @@ createComponent: componentName
self inform: '''', componentName, ''' is not a valid name for a component. Component names should begin with a letter. Please choose again.'.
^ nil ].

userComponent := WAComponent
subclass: componentName
instanceVariableNames: ''
classVariableNames: ''
poolDictionaries: ''
category: 'Seaside-User-Examples'.
userComponent := GRPlatform current
subclassOf: WAComponent
named: componentName
categorized: 'Seaside-User-Examples'.

userComponent isNil ifTrue: [
self inform: 'A problem occurred creating ''', componentName, ''' component..'.
Expand Down
4 changes: 1 addition & 3 deletions repository/Seaside-Welcome.package/monticello.meta/categories.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
SystemOrganization addCategory: #'Seaside-Welcome'!
SystemOrganization addCategory: #'Seaside-Welcome-Base'!
SystemOrganization addCategory: #'Seaside-Welcome-Examples'!
self packageOrganizer ensurePackage: #'Seaside-Welcome' withTags: #(#Base #Examples)!
Loading