Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random improvements #1432

Merged
merged 3 commits into from
Jul 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
seasideVersion
"Answer the Seaside version"

^ (GRVersion major: 3 minor: 5 revision: 8)
^ (GRVersion major: 3 minor: 5 revision: 9)
yourself
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
*Seaside-HotwireTurbo-Core
turboShow: aComponent

aComponent addDecoration: (WATurboFrame newWithId: self turboframeDecoration id).
^ self show: aComponent

Check warning on line 5 in repository/Seaside-HotwireTurbo-Core.package/WAComponent.extension/instance/turboShow..st

View check run for this annotation

Codecov / codecov/patch

repository/Seaside-HotwireTurbo-Core.package/WAComponent.extension/instance/turboShow..st#L1-L5

Added lines #L1 - L5 were not covered by tests
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ renderContentOn: html
| id |
html listItem
id: (id := html nextId);
onDoubleClick: (html javascript turboCallback: [ self turboCall: (WATurboTodoItemEditor on: self) ]);
onDoubleClick: (html javascript turboCallback: [ self turboShow: (WATurboTodoItemEditor on: self) ]);
with: [
html div
class: 'view';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ renderDescriptionOn: html
html label: description.
html anchor
class: 'edit-link';
callback: [ self turboCall: (WATurboTodoItemEditor on: self) ];
callback: [ self turboShow: (WATurboTodoItemEditor on: self) ];
with: 'edit'
Original file line number Diff line number Diff line change
@@ -1 +1 @@
SystemOrganization addCategory: #'Seaside-HotwireTurbo-Examples'!
self packageOrganizer ensurePackage: #'Seaside-HotwireTurbo-Examples' withTags: #()!
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,15 @@
url: 'http://book.seaside.st/';
with: 'Seaside Book'.
html text: ' will teach you all you need to know about Seaside and how to build killer web applications.' ].
html listItem: [
html text: 'The '.
html anchor
url: 'https://github.com/SeasideSt/Seaside/wiki';
with: 'Seaside Github wiki'.
html text: ' is where we keep our most up-to-date reference documentation.' ].

Check warning on line 19 in repository/Seaside-Welcome.package/WAWelcomeGettingStarted.class/instance/renderDocumentationStepOn..st

View check run for this annotation

Codecov / codecov/patch

repository/Seaside-Welcome.package/WAWelcomeGettingStarted.class/instance/renderDocumentationStepOn..st#L14-L19

Added lines #L14 - L19 were not covered by tests
html listItem: [
html text: 'The '.
html anchor
url: 'http://www.swa.hpi.uni-potsdam.de/seaside/tutorial';
url: 'http://www.hpi.uni-potsdam.de/hirschfeld/seaside/tutorial/';

Check warning on line 23 in repository/Seaside-Welcome.package/WAWelcomeGettingStarted.class/instance/renderDocumentationStepOn..st

View check run for this annotation

Codecov / codecov/patch

repository/Seaside-Welcome.package/WAWelcomeGettingStarted.class/instance/renderDocumentationStepOn..st#L23

Added line #L23 was not covered by tests
with: 'Seaside Tutorial'.
html text: ' has 12 chapters and introduces a sample application to explain the main features of Seaside.' ] ]
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,13 @@
html anchor
callback: [ self show: WAWelcomeExampleFlow new ];
with: 'Task'.
html text: ', illustrating Seaside''s innovative approach to application control flow.' ] ]
html text: ', illustrating Seaside''s innovative approach to application control flow.' ].
html listItem: [
html anchor
callback: [ self show: WATodo new ];
with: 'Todo'.
html text: ', the Seaside implementation of the example on '.
html anchor
url: 'https://todomvc.com/';
target: '_blank';
with: 'https://todomvc.com/' ] ]

Check warning on line 32 in repository/Seaside-Welcome.package/WAWelcomeGettingStarted.class/instance/renderExamplesStepOn..st

View check run for this annotation

Codecov / codecov/patch

repository/Seaside-Welcome.package/WAWelcomeGettingStarted.class/instance/renderExamplesStepOn..st#L23-L32

Added lines #L23 - L32 were not covered by tests
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
SystemOrganization addCategory: #'Seaside-Welcome'!
SystemOrganization addCategory: #'Seaside-Welcome-Base'!
SystemOrganization addCategory: #'Seaside-Welcome-Examples'!
self packageOrganizer ensurePackage: #'Seaside-Welcome' withTags: #(#Base #Examples)!
Loading